Planning and review artifacts written by /plan-task, /plan-epic, /review-multiple-prs, and /critique live outside the repo under:
TEMP_DIR=$TEMP_ROOT/<repo-name>/<branch-name>
$TEMP_ROOT is the human’s FARTY_BOBO_TEMP_DIR env var, falling back to /tmp when it is unset, empty, or not an absolute path. A leading ~/ (or a bare ~) is expanded to $HOME by the block itself, since settings.json env values are never shell-expanded; ~user/ forms are not supported and fall back. The human owns the root; each skill owns the layout beneath it. Never hardcode /tmp in a skill — always go through $TEMP_ROOT, resolved with the canonical temp-root block below. Every skill that uses FARTY_BOBO_TEMP_DIR carries a byte-identical copy of that block (between the # >>> temp-root and # <<< temp-root markers); tests/test-temp-root.sh fails if any copy drifts. If the block prints its WARNING, surface it to the human.
Resolve $TEMP_ROOT, <repo-name>, and <branch-name> using exactly these commands — there is one code path, correct both inside and outside a worktree. Do not substitute variants.
# >>> temp-root (canonical: skills/critique/SKILL.md; tests/test-temp-root.sh enforces sync)
TEMP_ROOT="${FARTY_BOBO_TEMP_DIR:-/tmp}"
case "$TEMP_ROOT" in
"~") TEMP_ROOT="$HOME" ;;
"~/"*) TEMP_ROOT="$HOME/${TEMP_ROOT#"~/"}" ;;
esac
TEMP_ROOT="${TEMP_ROOT%/}"
case "$TEMP_ROOT" in
/?*) ;;
*) echo "WARNING: FARTY_BOBO_TEMP_DIR must be an absolute path (got '$FARTY_BOBO_TEMP_DIR'); falling back to /tmp" >&2
TEMP_ROOT=/tmp ;;
esac
# <<< temp-root
repo_name=$(basename "$(dirname "$(git rev-parse --path-format=absolute --git-common-dir)")")
branch_name=$(git branch --show-current)
# Detached HEAD (mid-rebase, mid-bisect, CI checkout) returns an empty branch name.
[ -n "$branch_name" ] || branch_name="detached-$(git rev-parse --short HEAD)"
TEMP_DIR="$TEMP_ROOT/$repo_name/$branch_name"
Do not use git rev-parse --show-toplevel (returns the worktree path, not the main repo root) and do not use git rev-parse --git-common-dir | xargs dirname — outside a worktree that returns .git, so dirname yields . and TEMP_DIR silently becomes $TEMP_ROOT/./<branch-name>. It appears to work, but the repo-name namespacing is gone and two different repos on the same branch name overwrite each other’s artifacts with no error.
Resolve once, then use literal paths. Shell state does not persist between Bash calls, and Write/Edit do not expand variables. Resolve $TEMP_DIR once, echo the resolved absolute path to the human, and use that literal path in every later Write/Edit/Bash call and in every spawned-agent prompt. Create directories with (umask 077; mkdir -p "<dir>") and write files under the same umask — unlike mkdir -p -m 700, this also protects the intermediate directories, not just the leaf.
Nested paths: branch names routinely contain slashes (chore/foo, feat/bar), so $TEMP_DIR is a nested directory path, often two or more levels deep. Always create it with (umask 077; mkdir -p "$TEMP_DIR") — a plain write into a not-yet-existing nested path fails. Note that sibling branches chore and chore/foo cannot both have a temp dir (one would need to be a file’s parent and a directory at once); if mkdir -p fails for this reason, tell the human rather than skipping the write.
macOS note: when $TEMP_ROOT is under /tmp, /private/tmp, or /var/folders (including the default), it is cleared on reboot (/tmp → /private/tmp), and macOS periodic cleanup can also delete old files there without a reboot. Everything under $TEMP_DIR usually survives context compaction within a session, but that is not guaranteed for long sessions, and it does not survive a reboot. If a session spans a reboot, the human will need to re-state decisions manually. If FARTY_BOBO_TEMP_DIR points at a persistent location (e.g. $HOME/.farty-bobo/tmp), artifacts survive reboots — but they also accumulate, so the human is responsible for pruning them.
Legacy root fallback: if a decisions file is missing under $TEMP_DIR and $TEMP_ROOT is not /tmp, Step 10 also checks the default root, because the file may have been written before FARTY_BOBO_TEMP_DIR was set or from a session that could not see it.
enable and run githooks in the repos impacted by the code changes and fix errors (linting, type checks, tests) before committing. Most repos have dedicated commands to achieve these goals either in package.json or pyproject.toml.
Skipped-test check — MANDATORY. Do not present review options or proceed to commit until this check is resolved. Inspect the added lines only in the diff (lines beginning with +) for skip directives (see the canonical list in the Skip directives section below). Only flag directives that appear on added lines — do not flag pre-existing skips in unrelated hunks. If any are found, surface them to the human as HIGH severity findings and require an explicit written reason for each before proceeding. Critics will NOT separately flag these; this pre-check is the sole owner of skipped-test findings to avoid double-reporting.
Prompt the human to select their preferred review options:
/modularity:review to analyze coupling across modules using the Balanced Coupling model. Best for changes that introduce or restructure component boundaries, touch multiple modules, or modify public APIs/contracts./codex:reviewUNCONDITIONAL WRITE MANDATE — applies to every option above, no exceptions.
Whichever option the human picks — generalist, team, modularity, Codex, or manual — the orchestrator MUST write $TEMP_DIR/_critique-consolidated.md per Step 5 before presenting any findings in the conversation. Only the generalist and team flows spawn agents, but the mandate is not about agents; it is about never letting review findings exist solely in a conversation that will be compacted away. Specifically:
/modularity:review completes, the summary must inline its findings or link the document modularity:document produced. A separate document elsewhere does not satisfy this — the consolidated file must stand alone as a record of what was reviewed and what was found./codex:review, record its findings in the summary. If the human never reports back, write the summary with REVIEW INCOMPLETE — Codex review requested, no result reported in the header.reviewed by human, no findings raised — that is a real result and belongs on disk.Skip directives — canonical list (used by Step 3 and critic prompts):
test.skip, it.skip, xit, xdescribe, @pytest.mark.skip, t.Skip(, pending, or any framework-equivalent skip/todo/pending marker.
How to run critics:
All critics use a file-based output contract. The orchestrator hands the agent a temp file path; the agent writes its findings there and goes idle; the orchestrator reads the file.
Critic output files live under TEMP_DIR (same convention as the rest of this skill — see the Temp Directory section above):
$TEMP_DIR/critique-{summary}.md where {summary} is a short kebab-case slug of the change (e.g. fix-auth-redirect, skill-patch).$TEMP_DIR/critique-{specialty}.md per agent (e.g. critique-security.md, critique-correctness.md).$TEMP_DIR/_critique-consolidated.md — see Step 5.Reserved name: _critique-consolidated.md belongs to the orchestrator alone. Never assign it to a critic, and never let a {summary} or {specialty} slug produce it. The leading underscore exists precisely so no kebab-case slug can collide with it — if a critic and the consolidated file ever shared a path, the orchestrator’s later write would silently destroy the critic’s raw findings.
Record the mapping at dispatch time, not at Step 5. Immediately after spawning critics — before waiting on any of them — write a stub _critique-consolidated.md containing the header and a critic name → output file path line for every critic dispatched. Step 5 then fills in findings. This way the mapping survives a context compaction between dispatch and Step 5, and a run that dies mid-review still leaves evidence of what was attempted.
Resolve ticket-id by checking the current branch name or conversation context; use [NO-TICKET] if none is found (the bracketed form is the commit-prefix sentinel used everywhere below). Create TEMP_DIR with (umask 077; mkdir -p "$TEMP_DIR") before spawning any agents.
Adversarial framing — applies to ALL critic agents (generalist, team, and inline fallback reasoning):
Every critic must be prompted as an adversary, not a passive reviewer. Include this instruction in every critic’s prompt, and apply it when falling back to inline reasoning: “You are an adversarial critic. Assume the code is wrong until proven otherwise. Your job is to attack this change — find bugs, security holes, broken invariants, missing edge cases, and bad design decisions. Be aggressive. Do not give the benefit of the doubt. If something looks suspicious, call it out. Findings that survive scrutiny are more valuable than polite observations.”
Portable Markdown — applies to ALL critic output files and the consolidated file:
Humans open these files in editor previews (Cursor, VS Code, Obsidian), and some previews stop rendering everything after a code fence that never closes. Paste this block verbatim into every critic’s prompt, and follow it when writing _critique-consolidated.md:
Write portable Markdown. Never put a fenced code block inside a list item: end the list, leave a blank line, and put the fence at column 0. When the fenced content itself contains backticks, fence it with a longer run of backticks or with tildes; the opening and closing fences must match in character, length, and indentation. Leave a blank line before and after every heading, list, table, and fence. No raw HTML. Never leave a bare
$in prose: shell variables and dollar amounts go in backticks. Backtick identifiers, paths, and any<,>,|,*,_, or$meant literally; Markdown emphasis is fine.
When inlining another skill’s or critic’s output into the consolidated file (e.g. /modularity:review findings), normalize it to these rules instead of pasting it verbatim.
HARD GUARD — NO ASSUMPTIONS, EVER. Read this before spawning any critic.
The orchestrator MUST NOT proceed to the “Present findings” step until it has positive, explicit confirmation that every spawned critic has finished. Critics have taken longer than expected in the past, and the orchestrator wrongly reported “nothing found” while a critic was still working — this led the human astray with a false clean bill. That failure mode is now explicitly forbidden. This is the one rule everything below hinges on:
A critic’s Agent tool call returning is NOT the same as the critic finishing. By default agents run in the background (
run_in_background: true), and a background call returns control to the orchestrator at dispatch time — while the agent keeps working. The orchestrator must wait for that specific agent’s completion/idle notification. Never read, touch, or summarize a critic’s output file before that notification arrives, no matter how the tool call itself behaved.
Supporting rules:
One generalist critic:
a. Create TEMP_DIR with (umask 077; mkdir -p "$TEMP_DIR").
a2. Immediately after spawning (see b), write the stub _critique-consolidated.md with the critic name → output file mapping, per the “Record the mapping at dispatch time” rule above.
b. Spawn a single Agent with a focused prompt containing: the full diff, the repo name, the task description, the output file path, the adversarial framing above, and the Portable Markdown rules above (verbatim). Instruct it to write findings sorted by severity (HIGH / MEDIUM / LOW) to that file, or write “no findings” if nothing is worth raising. Do NOT instruct the critic to flag skipped tests — the Step 3 pre-check owns that. Keep the prompt tight — do not dump the full conversation history into it.
c. Wait for the completion notification, not the tool call return. Do not read the output file until this specific agent has reported idle/complete, per the HARD GUARD above. Apply the bounded-wait rule if it never reports.
d. Once completion is confirmed (or the bounded wait expires), read the output file.
e. If the file is missing or empty, fall back to inline reasoning using the adversarial framing above — and disclose to the human that the critic produced no output file (and, if applicable, that the bounded wait expired) and this review is inline-only.
f. Present findings to the human (global Step 5).
Team of critics:
a. Create TEMP_DIR with (umask 077; mkdir -p "$TEMP_DIR").
a2. Immediately after spawning (see b), write the stub _critique-consolidated.md with each critic’s name → output file mapping, per the “Record the mapping at dispatch time” rule above.
b. Spawn one Agent per specialty (e.g. security, performance, correctness) — each with its own output file path, the adversarial framing above, and the Portable Markdown rules above (verbatim). Do NOT instruct critics to flag skipped tests — the Step 3 pre-check owns that. Run all agents in parallel (single message, multiple Agent tool calls).
c. Wait for every single one’s completion notification, not their tool call returns. Track each critic by name/id. Do not read any output file, and do not proceed to (d), until you have confirmed real completion for ALL spawned critics per the HARD GUARD above. A subset finishing early does not authorize acting on partial results. Apply the bounded-wait rule per-critic to any that never report.
d. Once all critics have confirmed completion (or their bounded waits expire), read all output files.
e. For any file that is missing or empty, fall back to inline reasoning for that specialty using the adversarial framing above — and disclose to the human which critics produced no output (and, if applicable, which bounded waits expired) and that those portions are inline-only.
f. Synthesize all findings into a single sorted list, deduplicating overlapping issues across agents. Present to the human (global Step 5).
Write the consolidated findings to disk, then present them to the human.
Write first, present second, unconditionally. Run (umask 077; mkdir -p "$TEMP_DIR") as the first action of this step (harmless if it exists), then write the synthesized findings to $TEMP_DIR/_critique-consolidated.md before showing anything in the conversation. Write it even when the review was clean, when every critic failed, and when the human is about to ignore the findings — a missing file is indistinguishable from a review that never ran. If the mkdir or the write fails, say so plainly to the human instead of quietly presenting findings in chat only.
This file survives context compaction within the session, which the conversation does not. It does not survive a reboot — see the macOS note above. For a record that outlives the machine, reference it from the PR (Step 8a) or the Decision Log (Step 10).
Contents:
uncommitted changes reviewed on top of {short-sha} — Step 5 runs before the commit, so git rev-parse --short HEAD is the commit preceding the reviewed changes. Never label it as the commit containing them.file:line, what’s wrong, and the recommended fix._Pending human decision._ until Step 5b.Never write a clean verdict for a failed run. Only write “no findings” if at least one critic — or a disclosed inline fallback — actually completed and reported clean. If every critic failed to produce output, the header must read REVIEW INCOMPLETE — no critic produced output. Writing “no findings” because nothing was reported is the same false clean bill the HARD GUARD above exists to prevent.
Then present the findings in the conversation and echo the paths: the _critique-consolidated.md path plus every per-critic file path. If $TEMP_ROOT is under /tmp, /private/tmp, or /var/folders, tell the human $TEMP_DIR dies on reboot, so they should copy what they want to keep.
Then prompt them to select the next step:
5b. Update the consolidated file to match reality — run this before Step 6, on both branches above.
FIXED, IGNORED, or DEFERRED in the disposition section, and refresh the diff-base line — the tree the original SHA described no longer exists.Do not leave a summary claiming open issues that are already resolved, or a diff base that points at a stale tree.
git branch --show-current and compare against the repo’s default branch (typically main or master).
{branch} (the default branch). Committing directly here is not recommended. Should I create a new branch first, or do you explicitly approve committing to {branch}?”git checkout -b {branch-name}), then continue.[NO-TICKET] as a fallback.
_critique-consolidated.md is current per Step 5b. Do not commit alongside a stale summary.review-draft-*.md, critique-*.md, _critique-consolidated.md, plans/*.plan.md, plans/decisions-*.md, plans/stubs/**) are written to $TEMP_DIR ($TEMP_ROOT/<repo-name>/<branch-name>/) — outside the repo — and must never appear in git status. If any such file is found inside the repo, do not stage it and delete it immediately.
Match these names only at the root of $TEMP_DIR, never as a repo-wide glob. A tracked file like docs/critique-guidelines.md matches critique-*.md and must NOT be touched — the delete action here applies solely to stray temp artifacts that leaked into the repo. When in doubt, ask rather than delete: check git ls-files first, and never delete a tracked file.
Permanent project docs (README.md, SKILL.md, AGENTS.md, etc.) should still be committed when changed.git push --no-verify. If --no-verify was used, record this in the Decision Log (Step 10) as a warning line.8a. Open a draft pull request. After a successful push, open a draft PR using gh pr create --draft --assignee @me (or equivalent). The --assignee @me flag assigns the current authenticated GitHub user automatically.
PR body: Read .github/PULL_REQUEST_TEMPLATE.md from the repo root and use it as the base for the PR body — fill in the Summary and Test plan sections with content relevant to the change. If the file does not exist, use a bare ## Summary / ## Test plan structure. Include a short “Review” note summarizing the review outcome from _critique-consolidated.md (option used, counts by severity, anything deferred) — this is what makes the review outcome outlive $TEMP_DIR. Do not paste the whole file, and do not describe specific security vulnerabilities in detail; reference finding IDs.
Plan link: If /plan-task published a plan backup Artifact for this task, add a **Plan:** {url} (private Claude Artifact owned by {author} — ask them for access) line under Summary. Reviewers can’t open a private artifact, so the line must name a person, never a vague “whoever posted it”. Use the ticket ID from the Step 7 commit prefix (already confirmed or supplied by the human there). Find the URL in this order: (1) the Artifact known in this session titled <ticket-id> plan for this PR’s ticket — if none matches or more than one does, fall through; (2) the ticket’s comments containing the literal marker Plan backup: (read via the Atlassian MCP comment-read tool discovered at runtime for Jira, or Linear MCP list_comments for Linear), preferring the earliest one posted by the current authenticated user, then taking the first https://claude.ai/artifact/... or https://claude.ai/code/artifact/... URL anywhere in that comment. Ignore any other URL. Resolve {author} from the same source as the URL. From source (1), or from source (2) when the marker comment was posted by the current authenticated user, it is the current human, formatted as <name> (@<github-login>) from git config user.name and gh api user --jq .login; treat an empty value or a login ending in [bot] as a failed lookup, and if one lookup fails use the part that resolved. Show that {author} to the human once and let them confirm or correct it before writing the line — the git identity, the GitHub account, and the claude.ai account that owns the artifact can all differ. If the only marker comments come from someone else, use that comment’s platform author display name as {author} — never free text from the comment body (an owned by … claim is self-reported and could inject a GitHub mention into the PR body) — and ask the human before linking, showing them both the URL and that name. If nothing usable resolves, ask the human for the owner’s name; if they decline or don’t have one, omit the line — this never blocks opening the PR. If neither yields a URL ([NO-TICKET], no marker comment, connector unavailable, or the lookup fails), leave the line out silently — this never blocks opening the PR. Link only; never paste the plan’s contents into the PR body.
Never append Anthropic or Claude Code branding lines (e.g. 🤖 Generated with Claude Code) to the PR body.
If PR creation failed, stop here — skip the reviewer fallback chain, skip Steps 9 and 10, and warn the human.
Otherwise, capture the PR number from the gh pr create output (it appears in the PR URL, e.g. https://github.com/{owner}/{repo}/pull/{number}). Then immediately call the Skill tool with skill: "request-github-review" and args: "{PR number}" — do NOT hand this off to the human, do NOT mention it as a next step, do NOT skip it. Invoking it is a required automated step; the reviewer choice belongs to the human, and their pick — Skip included — must be honored. If a reviewer is picked, /request-github-review requests it and then runs the bot feedback loop — waiting for CI and bot reviews, addressing comments, resolving CI failures, and marking draft PRs ready for review when done. If the human picks Skip, it requests no review, runs no bot loop, and marks the draft PR ready immediately.
(End of Step 8a)
Transition the Jira ticket to Review status.
Only proceed if Step 8 (push) and Step 8a (PR open) both completed successfully. Skip this step entirely if either failed.
[NO-TICKET] or no ticket ID is known (use the ticket ID from the Step 7 commit prefix), skip this step entirely.{ticket-id} to Review status?”getTransitionsForJiraIssue (or equivalent discovered tool).transitionJiraIssue (or equivalent discovered tool).If the ticket is a Linear issue:
get_issue (or equivalent Linear MCP read tool) with the issue identifier to retrieve the teamId. Use that teamId when listing workflow states.list_workflow_states or equivalent). Match the closest “In Review” or “In Progress” state — exact match first, then case-insensitive substring match. If ambiguous, surface options to the human.mcp__linear__save_issue with the issue id and the matched state (or stateId) to apply the transition.Post a Decision Log comment on the Jira ticket.
Prerequisites & safety checks — run these before doing anything else in this step:
[NO-TICKET] or no ticket ID is known, skip this step entirely.{ticket-id}?”Decision sources — use only these, in order of preference:
decisions-{ticket-id}.md scratch file written by /plan-task during this session — look for it at $TEMP_DIR/plans/decisions-{ticket-id}.md (read and then delete it after posting). If it is missing there and $TEMP_ROOT is not /tmp, also check the legacy default root at /tmp/<repo-name>/<branch-name>/plans/decisions-{ticket-id}.md; if it is found there, tell the human it came from the legacy/default rootContent rules:
Idempotency — one comment per ticket, ever:
## Decision Log.--no-verify was used in Step 8, include ⚠️ Pushed with --no-verify — pre-push hooks were bypassed. at the top of the comment body.Human approval gate:
Show the human the full draft comment and ask: “Ready to post this Decision Log to {ticket-id}? (yes / edit / skip)” — do not post without explicit confirmation.
Identity disclosure (required): The comment body MUST begin with your identity line (as defined in CLAUDE.md) so readers don’t mistake the Decision Log for something the human typed themselves. When overwriting an existing Decision Log comment, refresh this line — do not leave the old one in place.
Comment format:
## Decision Log
_Posted by {your identity} on behalf of @<github-or-jira-handle>._
_Last updated: YYYY-MM-DD — Push SHA: {short-sha}_
### Planning
- <decision: what was chosen and what was the alternative, e.g. "Chose REST over GraphQL — GraphQL deferred to follow-up">
### Implementation
- <key implementation choice approved by the human>
### Review
- <review outcome, e.g. "Deferred MEDIUM-3 to FOO-456">
### Open Items
- <deferred item> — [FOO-456](link) or "no follow-up ticket yet"
⚠️ Pushed with --no-verify — pre-push hooks were bypassed. ← include only if applicable
Only include sections that have content. Omit empty sections entirely.
If the ticket is a Linear issue:
--no-verify was used in Step 8, include ⚠️ Pushed with --no-verify — pre-push hooks were bypassed. at the top of the comment body.## Decision Log. If found, use mcp__linear__save_comment with the existing comment id to overwrite it. If not found, create a new comment (omit id).mcp__linear__save_comment with issueId set to the Linear issue identifier and body as the Decision Log in Markdown format (Linear supports Markdown natively — no ADF conversion needed).{issue-id}? (yes / edit / skip)” — do not post without explicit confirmation.The Decision Log format is the same as the Jira version (same ## Decision Log header, same sections) — just in Markdown instead of Jira wiki markup.